feat: build firefox_history_locales.json for the nightly channel#1987
feat: build firefox_history_locales.json for the nightly channel#1987bhearsum wants to merge 2 commits into
Conversation
|
I should also add: https://bugzilla.mozilla.org/show_bug.cgi?id=2047022 is looking at getting |
bhearsum
force-pushed
the
feat-build-firefox-locales.jso
branch
from
5f0b885 to
81d4267
Compare
bhearsum
force-pushed
the
feat-build-firefox-locales.jso
branch
from
81d4267 to
bbc5380
Compare
|
Any thoughts on what happens / should happen for locales that are discontinued? |
To be honest, I wasn't planning to do anything about them just yet. I don't think we need them to support the use case I'm adding this for (update integrity tests) because such locales won't be present in |
|
(The easy/stupid thing to do would be to add |
bhearsum
changed the title
bhearsum
force-pushed
the
feat-build-firefox-locales.jso
branch
2 times, most recently
from
dfd5659 to
bfe4b83
Compare
| query = db_session.query(NightlyRelease) | ||
| query = query.filter(NightlyRelease.product == product) | ||
| query = query.filter(NightlyRelease.channel == channel) | ||
| return query.all() |
There was a problem hiding this comment.
Can we avoid grabbing all nightlies? This seems unlikely to scale well.
There was a problem hiding this comment.
Added this in a subsequent commit.
This adds initial support for the new `firefox_history_locales.json` file described in https://bugzilla.mozilla.org/show_bug.cgi?id=2042596. It's focused on just the Nightly channel initially; I plan to follow-up in fairly short order with support for other channels. In order for this to work correctly in production I'll need to first backfill with metadata from each Nightly that added locales, and a recent Nightly. With that done, we'll end up with [this firefox_locales.json](https://gist.github.com/bhearsum/cff2f1bef5cd0d81b90b7e92a1f72c92). (I have that metadata and a script prepared locally to do this; I can share it if it's useful.) We should also wait until [automatic nightly submission](https://phabricator.services.mozilla.com/D304523) is landed to merge this to ensure it updates correctly the next time a locale is added or removed.
We're probably never going to stop early in reality, but batching at least constrains the memory usage and spreads out the database load.
bhearsum
force-pushed
the
feat-build-firefox-locales.jso
branch
from
bfe4b83 to
4dfb4ff
Compare
3 participants
This adds initial support for the new
firefox_history_locales.jsonfile described in https://bugzilla.mozilla.org/show_bug.cgi?id=2042596.It's focused on just the Nightly channel initially; I plan to follow-up in fairly short order with support for other channels.
In order for this to work correctly in production I'll need to first backfill with metadata from each Nightly that added locales, and a recent Nightly. With that done, we'll end up with this firefox_locales.json. (I have that metadata and a script prepared locally to do this; I can share it if it's useful.)
We should also wait until automatic nightly submission is landed to merge this to ensure it updates correctly the next time a locale is added or removed.