Clarify and clean up experiment syncing#220
Open
freshstrangemusic wants to merge 1 commit into
Open
Conversation
RJAK11
reviewed
Jun 24, 2026
| name="collection" | ||
| id="collection" | ||
| className="mb-3" | ||
| disabled={disabled} |
Collaborator
There was a problem hiding this comment.
One small thing: I tried testing out the case where it should be disabled and for some reason the checkbox is still clickable which I assume wasn't intended?
The settings page has been renamed to the "Experiment Loader" page because all the controls are for experiment loading. Copy has been added that describes what each control does. Updating with `forceSync: true` is no longer supported as it usually won't work due to returning stale cached records from Remote Settings. We now return both the cached value of the experiments collection (i.e., what collection Nimbus is currently using) and the current value of the collection pref when requesting the current collection. We use this information to inform users that they must restart their browser when switching to the preview collection. The collection controls have been simplified to a single checkbox which enables the preview collection. The ability to set custom collections has been removed and now this page will be disabled if it detects a custom collection. Fixes #74
freshstrangemusic
force-pushed
the
freshstrangemusic/push-tottxxslmxpv
branch
from
db69f69 to
453ac5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings page has been renamed to the "Experiment Loader" page because all the controls are for experiment loading. Copy has been added that describes what each control does.
Updating with
forceSync: trueis no longer supported as it usually won't work due to returning stale cached records from Remote Settings.We now return both the cached value of the experiments collection (i.e., what collection Nimbus is currently using) and the current value of the collection pref when requesting the current collection. We use this information to inform users that they must restart their browser when switching to the preview collection.
The collection controls have been simplified to a single checkbox which enables the preview collection. The ability to set custom collections has been removed and now this page will be disabled if it detects a custom collection.
Fixes #74