Add velocity and acceleration scaling when using custom limits in Time Parameterization - #1832
Conversation
…ime parameterization
Codecov ReportBase: 50.46% // Head: 50.39% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1832 +/- ##
==========================================
- Coverage 50.46% 50.39% -0.06%
==========================================
Files 374 374
Lines 31335 31363 +28
==========================================
- Hits 15809 15803 -6
- Misses 15526 15560 +34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
54eba67 to
b073888
Compare
sjahr
left a comment
There was a problem hiding this comment.
Thanks for these changes! I think this looks good in general. Just out of curiosity, is your work with the Hybrid Planner and dynamic joint limits open source?
Yep! I have it all available on my forks. I have implemented the changes across MoveIt, MTC, and moveit_msgs with some help from @AndyZe. It's just a matter of creating modular PRs to the relevant repos to get it all integrated. |
|
Thanks for the PR @mechwiz ! |
7baf50d to
b5d774e
Compare
Description
In an effort to use dynamic joint velocity, acceleration, or jerk limits it was mentioned by @henningkayser in my moveit_msgs PR here moveit/moveit_msgs#144 (comment) that scaling should be applied regardless if using default limits or custom limits. This PR creates the necessary changes to accomplish this.
@AndyZe
EDIT
This PR also adds another overloaded
computeTimeStampsfunction for passing in a vector of JointLimit messages. I found this to be easier to work with in my implementation for integrating dynamic joint limits.Checklist