Blue fallback rolling auction negative - #1128
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62415a703d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| require(msg.sender == MIDNIGHT, NotMidnight()); | ||
|
|
||
| (address caller, bytes memory callerData) = abi.decode(data, (address, bytes)); |
There was a problem hiding this comment.
Checking only msg.sender == MIDNIGHT does not prove this callback originated from roll: an attacker can call Midnight.repay on their own behalf with zero units, select this contract as the callback, and encode any target roller and payload in data. Any roller that trusts calls from this contract can therefore have its onRepay logic triggered with forged parameters; store and validate the active roll/caller context before forwarding the callback.
Useful? React with 👍 / 👎.
|
Not planned after this |
1 participant
No description provided.