fix(release:PLA-1355): harden version tag input#65
Open
0x666c6f wants to merge 2 commits intomorpho-mainfrom
Open
fix(release:PLA-1355): harden version tag input#650x666c6f wants to merge 2 commits intomorpho-mainfrom
0x666c6f wants to merge 2 commits intomorpho-mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5459191362
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR hardens the GitHub Actions release workflow’s workflow_dispatch version_tag handling to prevent template injection and reduce unsafe interpolation in shell steps.
Changes:
- Added a Bash validation step for
version_tagand routed the validated value through step/job outputs. - Replaced direct
${{ github.event.inputs.version_tag }}interpolation inrun:scripts with environment variables populated from the validated output. - Quoted
$GITHUB_OUTPUTwrites and grouped multiple output writes to satisfy actionlint-style safety checks.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Linear