Skip to content

fix(release:PLA-1355): harden version tag input#65

Open
0x666c6f wants to merge 2 commits intomorpho-mainfrom
feature/pla-1355-erpc-harden-release-workflow-against-version_tag-template
Open

fix(release:PLA-1355): harden version tag input#65
0x666c6f wants to merge 2 commits intomorpho-mainfrom
feature/pla-1355-erpc-harden-release-workflow-against-version_tag-template

Conversation

@0x666c6f
Copy link
Copy Markdown
Collaborator

@0x666c6f 0x666c6f commented May 6, 2026

Summary

  • Harden release workflow_dispatch version_tag handling against template injection.

Changes

  • Add strict Bash semver validation through an env passthrough before release prep runs.
  • Replace raw version_tag interpolation inside run scripts with validated env/output values.
  • Quote existing workflow output writes flagged by actionlint.

Linear

Copilot AI review requested due to automatic review settings May 6, 2026 09:02
@0x666c6f 0x666c6f self-assigned this May 6, 2026
@linear
Copy link
Copy Markdown

linear Bot commented May 6, 2026

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5459191362

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/release.yml Outdated
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the GitHub Actions release workflow’s workflow_dispatch version_tag handling to prevent template injection and reduce unsafe interpolation in shell steps.

Changes:

  • Added a Bash validation step for version_tag and routed the validated value through step/job outputs.
  • Replaced direct ${{ github.event.inputs.version_tag }} interpolation in run: scripts with environment variables populated from the validated output.
  • Quoted $GITHUB_OUTPUT writes and grouped multiple output writes to satisfy actionlint-style safety checks.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/release.yml Outdated
Comment thread .github/workflows/release.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants