refactor(derivation): simplify local verify path, rename Path B to "l…#958
Conversation
…ocal verify" - Inline ParseBatchMetadataOnly into fetchBatchInfoOutline; drop the helper. Local verify is new-ABI only: lastBlockNumber from batch.LastBlockNumber, firstBlockNumber from parent header LastBlockNumber + 1. No parentVersion / BlockContexts branching. - Rename "Path B" -> "local verify" / "Local" across Go symbols, log fields, error messages, Prometheus metric names, CLI default value and Usage string, and tests. - Trim newly-added local-verify metrics: drop unused LocalVerifyFailed, LocalVerifyFailedByKind, and the three LocalVerifySelfHeal* counters (self-heal not yet implemented). Keep LocalVerifyTriggered as the only signal that the verifier is running. - Stop zeroing SafeL2BlockNumber gauge on L1 reorg reset; redefine its semantics as the highest verified L2 block watermark to avoid false alarms during reorg recovery. - Fix stale static_scan_test.go pointing to the renamed verify_local.go. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ocal verify"