Skip to content

refactor(derivation): simplify local verify path, rename Path B to "l…#958

Merged
curryxbo merged 1 commit into
feat/derivation-batch-verifyfrom
refactor/local-verify-cleanup
May 26, 2026
Merged

refactor(derivation): simplify local verify path, rename Path B to "l…#958
curryxbo merged 1 commit into
feat/derivation-batch-verifyfrom
refactor/local-verify-cleanup

Conversation

@curryxbo
Copy link
Copy Markdown
Contributor

…ocal verify"

  • Inline ParseBatchMetadataOnly into fetchBatchInfoOutline; drop the helper. Local verify is new-ABI only: lastBlockNumber from batch.LastBlockNumber, firstBlockNumber from parent header LastBlockNumber + 1. No parentVersion / BlockContexts branching.
  • Rename "Path B" -> "local verify" / "Local" across Go symbols, log fields, error messages, Prometheus metric names, CLI default value and Usage string, and tests.
  • Trim newly-added local-verify metrics: drop unused LocalVerifyFailed, LocalVerifyFailedByKind, and the three LocalVerifySelfHeal* counters (self-heal not yet implemented). Keep LocalVerifyTriggered as the only signal that the verifier is running.
  • Stop zeroing SafeL2BlockNumber gauge on L1 reorg reset; redefine its semantics as the highest verified L2 block watermark to avoid false alarms during reorg recovery.
  • Fix stale static_scan_test.go pointing to the renamed verify_local.go.

…ocal verify"

- Inline ParseBatchMetadataOnly into fetchBatchInfoOutline; drop the
  helper. Local verify is new-ABI only: lastBlockNumber from
  batch.LastBlockNumber, firstBlockNumber from parent header
  LastBlockNumber + 1. No parentVersion / BlockContexts branching.
- Rename "Path B" -> "local verify" / "Local" across Go symbols, log
  fields, error messages, Prometheus metric names, CLI default value
  and Usage string, and tests.
- Trim newly-added local-verify metrics: drop unused
  LocalVerifyFailed, LocalVerifyFailedByKind, and the three
  LocalVerifySelfHeal* counters (self-heal not yet implemented). Keep
  LocalVerifyTriggered as the only signal that the verifier is running.
- Stop zeroing SafeL2BlockNumber gauge on L1 reorg reset; redefine its
  semantics as the highest verified L2 block watermark to avoid false
  alarms during reorg recovery.
- Fix stale static_scan_test.go pointing to the renamed verify_local.go.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@curryxbo curryxbo requested a review from a team as a code owner May 25, 2026 14:14
@curryxbo curryxbo requested review from SecurityLife and removed request for a team May 25, 2026 14:14
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 25, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 055071ec-5b7b-4c04-b479-7a49823a8c0c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/local-verify-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@curryxbo curryxbo merged commit db38213 into feat/derivation-batch-verify May 26, 2026
6 of 7 checks passed
@curryxbo curryxbo deleted the refactor/local-verify-cleanup branch May 26, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant