You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This passes the itemIndex to the renderItem function, in cases where you need to know which index the item has, it might be helpful:
For example:
styling the first / last item
grouping by index and offset.
Numeration of the items inner the render function.. First. 2. 3.. Last:
(Yes, you can solve some of this by preparing the suggestions before you are passing them to the component (in case of React-Autosuggest), but this requires an additional loop before the rendering.
Maybe it's TOO MUCH :), but I am seriously thinking about an additional ItemsLength prop, which would be given to each renderItem.
The benefits are, that you don't have to use this.state.items.length in your parent component to know if this is the last or not.. Additionally this.state.items.length is maybe not the real source of truth because in your render, there could be a filter already suggestions={this.state.items.filter()} for example, so ItemList in this package is a better candidate to provide us this value?
@webdeb I like the thought, but I'd prefer to simply pass the whole suggestion array to the developer instead of passing just the length value. That way devs are not restricted to specific parts of an object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This passes the
itemIndexto therenderItemfunction, in cases where you need to know which index theitemhas, it might be helpful:For example:
(Yes, you can solve some of this by preparing the suggestions before you are passing them to the component (in case of React-Autosuggest), but this requires an additional loop before the rendering.