Skip to content

Fix disabled Passage routes failing with 500#100

Open
kingpy-bot wants to merge 1 commit into
morcen:mainfrom
kingpy-bot:kingpy/fix-disabled-route-97
Open

Fix disabled Passage routes failing with 500#100
kingpy-bot wants to merge 1 commit into
morcen:mainfrom
kingpy-bot:kingpy/fix-disabled-route-97

Conversation

@kingpy-bot

Copy link
Copy Markdown
Contributor

Fixes #97.

What changed

  • keep PassageServiceInterface container-resolvable when the master switch is off
  • return a fail-closed 404 before resolving the route handler or making any upstream request
  • add regression coverage for both disabled boot binding and disabled-route behavior

This preserves registered route definitions while making PASSAGE_ENABLED=false safely disable all proxying instead of failing during controller construction.

Verification

  • vendor/bin/pest: 105 tests passed, 263 assertions
  • vendor/bin/pint --test on all four touched files: passed
  • git diff --check: passed

AI-assisted implementation and verification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PASSAGE_ENABLED=false crashes registered routes instead of disabling them gracefully

1 participant