[repo] Show a warning for stable versions that newer docs are available.#1219
Open
andrewnicols wants to merge 1 commit intomoodle:mainfrom
Open
[repo] Show a warning for stable versions that newer docs are available.#1219andrewnicols wants to merge 1 commit intomoodle:mainfrom
andrewnicols wants to merge 1 commit intomoodle:mainfrom
Conversation
✅ Deploy Preview for moodledevdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
⚡️ Lighthouse report for the deploy preview of this PR
|
Member
|
Hi @andrewnicols! Thank you for working on this PoC to implement William Entriken's request at https://tracker.moodle.org/browse/MDLSITE-7820 :-) I understand your point, but I also see the benefits of displaying this banner for older versions. Perhaps we could consult the UX team for a less intrusive way to display it... Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[~sarjona]: Here's the alternative for #1217.
I 100% do not agree with doing this and I have no intention of landing this. It's a blight on the documentation and I feel that it serves no useful purpose but to add more junk on the top of the page and to push the useful part of the docs out of the immediate code window.
The pages you want to add this to are for fully supported versions of the codebase. I also do not agree that we should point people to docs for unstable versions of the codebase.
I won't land this.