-
Notifications
You must be signed in to change notification settings - Fork 1
ci: unified workflow (lint + typecheck + build + rust) #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kyscott18
wants to merge
8
commits into
smooth-transaction-volume-chart
Choose a base branch
from
ci/unified-frontend-workflow
base: smooth-transaction-volume-chart
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d32471a
fix(tps-chart): smooth Transaction volume line
dak-agent[bot] 4422195
fix(tps-chart): animate new data points instead of curving the line
dak-agent[bot] 1883c35
feat(tps-chart): smooth streaming via sliding time-window X axis
Camillebzd 0ec08b6
chore: update pnpm lockfile and allow sharp/unrs-resolver builds
Camillebzd e166c0e
chore: minimize lockfile diff vs main
dak-agent[bot] 75e5e79
ci: unified frontend workflow (lint + typecheck + build)
kyscott18 9817300
ci: add rust job (fmt + clippy + build)
kyscott18 d34b779
ci: run rust job in rust:1.91-slim container for libclang/bindgen parity
kyscott18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [main] | ||
| workflow_dispatch: | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/cache@v4 | ||
| with: | ||
| path: ~/.cache/biome | ||
| key: biome-${{ runner.os }}-${{ hashFiles('biome.json') }} | ||
| restore-keys: biome-${{ runner.os }}- | ||
| - uses: biomejs/setup-biome@v2 | ||
| with: | ||
| version: 2.1.2 | ||
| - run: biome ci --linter-enabled=true --formatter-enabled=true | ||
|
|
||
| typecheck: | ||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: frontend | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 10 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| cache: pnpm | ||
| cache-dependency-path: frontend/pnpm-lock.yaml | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm typecheck | ||
|
|
||
| build: | ||
| runs-on: ubuntu-latest | ||
| defaults: | ||
| run: | ||
| working-directory: frontend | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: pnpm/action-setup@v4 | ||
| with: | ||
| version: 10 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| cache: pnpm | ||
| cache-dependency-path: frontend/pnpm-lock.yaml | ||
| - run: pnpm install --frozen-lockfile | ||
| - run: pnpm build | ||
|
kyscott18 marked this conversation as resolved.
|
||
|
|
||
| rust: | ||
| runs-on: ubuntu-latest | ||
| # Match the backend Dockerfile's build image so bindgen sees a libclang | ||
| # new enough for the upstream C23 (`constexpr`) headers from monad-bft. | ||
| container: rust:1.91-slim | ||
| steps: | ||
| - name: Install build dependencies | ||
| run: | | ||
| apt-get update | ||
| apt-get install -y git curl gcc g++ cmake pkg-config libssl-dev libclang-dev libzstd-dev libhugetlbfs-dev | ||
| - uses: actions/checkout@v4 | ||
| - run: rustup component add rustfmt clippy | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - run: cargo fmt --all --check | ||
| - run: cargo clippy --all-targets --all-features -- -D warnings | ||
| - run: cargo build --all-targets | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next buildruns without required env varsfrontend/config/env.tsexposesNEXT_PUBLIC_EVENTS_WS_URLviagetEnvOrThrow, which throws if the variable is unset. While the getter is lazy and won't fire during the webpack compile pass itself, any page that callspublicEnv.EVENTS_WS_URLduring server-side rendering or static generation will causenext buildto throw and fail the job. Consider adding anenv:block (using GitHub Actions secrets) or providing dummy values so the build job gives reliable signal rather than potentially failing for a config reason instead of a code reason.Prompt To Fix With AI