chore: bundle sasso core 0.6.3 (drop trailing newline, dart-sass parity) - #1
Merged
Merged
Conversation
Bump the bundled core compiler crate from 0.6.0 to 0.6.3 (exact pin in native/Cargo.toml). Core 0.6.3 fixes the trailing-newline divergence: the C ABI is dart-sass's library API, which does NOT terminate output with `\n` (for both expanded and compressed), so `compile(...)` is now byte-for-byte identical to dart-sass `compileString().css`. - native/Cargo.toml: sasso_core pin =0.6.0 -> =0.6.3; crate version 0.6.0 -> 0.6.3 - native/src/lib.rs: refresh the vendored-header pin reference to =0.6.3 (the C ABI source itself is unchanged between 0.6.0 and 0.6.3) - __version__ 0.1.1 -> 0.1.2 - tests: drop the trailing newline from the expected CSS, add a regression test for both styles, and refresh the stale version asserts (0.1.2 / 0.6.3) Claude-Session: https://claude.ai/code/session_018hunqBr6AhWGu1dSJTEWMu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundles the
sassocompiler crate 0.6.3 (was 0.6.0), propagating thetrailing-newline parity fix to the Python package.
What changed
The C ABI is dart-sass's library API, which — unlike the
sassCLI — doesnot terminate its output with
\n. Core 0.6.3 fixed this, sosasso.compile(...)is now byte-for-byte identical to dart-sasscompileString().cssfor both expanded and compressed output.native/Cargo.toml:sasso_corepin=0.6.0→=0.6.3; crate version0.6.0→0.6.3native/src/lib.rs: refresh the vendored-header pin reference to=0.6.3(the vendored C ABI source is otherwise unchanged between 0.6.0 and 0.6.3 —
only
include/sasso.h-identical code; no re-vendor needed)__version__0.1.1→0.1.2covering both styles, and refresh the stale version asserts (
0.1.2/0.6.3)Verification
python scripts/build_native.py(cargo resolvedsasso v0.6.0 -> v0.6.3) +full
pytestagainst the freshly built lib: 16 passed.result straight to a
.cssfile), append it yourself:Path("out.css").write_text(sasso.compile(src) + "\n"). See CHANGELOG.https://claude.ai/code/session_018hunqBr6AhWGu1dSJTEWMu