Add click-outside hide preference - #74
Conversation
New Behavior toggle controls whether the bar hides when it loses key focus. Defaults to on, preserving current behavior. When pinned, the panel drops from .modalPanel to .floating so it stops covering full-screen apps, and the paste target keeps tracking the frontmost app via lastActiveApp. Co-authored-by: alvst <alvst@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce50d53fd8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
|
|
||
| var hideOnClickOutside: Bool { | ||
| didSet { guard isLoaded else { return }; d.set(hideOnClickOutside, forKey: Keys.hideOnClickOutside) } |
There was a problem hiding this comment.
When the preference is changed from off to on while the bar is already visible behind the Settings window, this setter only persists the value. The panel lost key status while the option was still off, so windowDidResignKey has already returned without hiding it; subsequent clicks in other apps produce no new resignation event, leaving the bar visible despite the enabled setting until the user focuses or toggles it again. Reconcile the currently presented panel when enabling this option.
Useful? React with 👍 / 👎.
Reworked from #22. Co-authored with @alvst.
Made with Cursor