ci: publish to PyPI via Trusted Publishing (OIDC)#251
Merged
Conversation
Drop the long-lived PYPI_TOKEN secret in favor of OIDC. uv publish auto-detects the GitHub Actions id-token, so the release job grants id-token: write and runs under a `pypi` environment that scopes the PyPI Trusted Publisher. Requires a matching Trusted Publisher on the modern-di PyPI project (workflow: release.yml, environment: pypi) before the next tag. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the long-lived
PYPI_TOKENsecret with PyPI Trusted Publishing (OIDC).Changes
release.yml: addid-token: write, run the job under apypienvironment, drop thePYPI_TOKENenv from the publish step.Justfile:uv publish --token $PYPI_TOKEN->uv publish(uv auto-detects the CI id-token).Why
No credential to leak or rotate; OIDC tokens are short-lived and scoped to this repo + workflow. This is PyPI's recommended path.
Required before merge / next tag (maintainer, PyPI-side)
Code alone can't enable this:
modern-diproject -> Publishing -> add a Trusted Publisher: ownermodern-python, repomodern-di, workflowrelease.yml, environmentpypi.pypienvironment under repo Settings -> Environments (add approval/wait-timer rules if wanted).PYPI_TOKENrepo secret.If 1-2 aren't in place when a tag is pushed, that publish fails; nothing auto-releases in between, and reverting this diff restores the token path.