refactor: rename OpentelemetryConfig → OpenTelemetryConfig; FreeBootstrapperConfig → FreeConfig#103
Merged
Merged
Conversation
…trapperConfig → FreeConfig Two API-surface renames with silent backward-compatibility aliases. OpentelemetryConfig → OpenTelemetryConfig: matches the conventional OpenTelemetry capitalization and the OpenTelemetryServiceFieldsConfig mixin introduced in PR6. Module-level alias `OpentelemetryConfig = OpenTelemetryConfig` preserves existing imports. Not exported from __init__.py (wasn't before either). FreeBootstrapperConfig → FreeConfig: matches the sibling configs (FastAPIConfig, LitestarConfig, FastStreamConfig — none carry the "Bootstrapper" infix). Module-level alias plus `FreeBootstrapperConfig` re-export in __init__.py preserves existing public imports. Internal references and tests updated to the new canonical names. Aliases are simple class assignments — same class object, so isinstance(x, OldName) and isinstance(x, NewName) are interchangeable. Old pickles continue to unpickle via the alias. No behavior change. 129/129 tests pass. Closes LOW-7 from the audit. Also closes the bonus Otel capitalization item surfaced during PR6's code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The final PR of the deferred-refactors sequence. Two API-surface renames with silent backward-compatibility aliases:
OpentelemetryConfig→OpenTelemetryConfig— matches the conventional OpenTelemetry capitalization and theOpenTelemetryServiceFieldsConfigmixin from PR6. Module-level alias preserves existing imports. Not exported from__init__.py(wasn't before).FreeBootstrapperConfig→FreeConfig— matches the sibling configs (FastAPIConfig,LitestarConfig,FastStreamConfig— none carry theBootstrapperinfix). Module-level alias plusFreeBootstrapperConfigre-export in__init__.pypreserves existing public imports.Internal references and tests updated to the new canonical names. Aliases are simple class assignments — same class object, so
isinstance(x, OldName)andisinstance(x, NewName)are interchangeable. Old pickles continue to unpickle via the alias.10 files modified, no behavior change. 129/129 tests pass.
Closes LOW-7 from an internal audit. Also closes the bonus Otel capitalization item surfaced during PR6's code review.
Test plan
just test— 129/129.just lint— clean.isinstance(x, OldName) is isinstance(x, NewName)for both renames).__init__.py).Why silent aliases
Locked decision in the sequencing spec: silent aliases (no warn-on-access). The library is small, and warn-on-access is overkill for two targeted renames where the new names are uncontroversially better.
🤖 Generated with Claude Code