docs: record deferred items + decisions from the architecture reviews#42
Merged
Conversation
- planning/deferred.md: commit_all flush latency on a transient-error re-queue — a deferred fix (correct fix needs retry-backoff; the naive 'keep flush urgency' approach busy-loops during outages), parked with its revisit trigger. - planning/decisions/: batch subscribers deliberately unsupported; the health delegation chain (review candidate #4) left as-is until health grows. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only. Records the calls and deferred items surfaced while shipping the architecture-review trio (#39–#41), each with a concrete revisit trigger so future reviews don't re-litigate them.
planning/deferred.md— adds commit_all flush latency on a transient-error re-queue to the Open register. This is a deferred fix, not a closed decision: a correct fix needs retry-with-backoff on the flush path (the naive "keep flush urgency across the re-queue" approach regresses the sustained-outage case into a busy-retry + log-spam loop), and the impact is niche (a transient commit error coinciding with a rebalance, on a sub-commit_batch_sizebatch). Parked with its trigger.planning/decisions/— two genuine calls:batch-subscribers-unsupported— the concurrent path is one-message-one-offset; batch (batch=True) is rejected with a clearRuntimeErrorrather than growing a second engine.health-delegation-chain-not-deepened— architecture review candidate small refactoring #4, left as-is until the health concept grows beyond a single boolean.No code changes.
🤖 Generated with Claude Code