Feature voronoi and EEZ extras#55
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
This was
linked to
issues
Apr 30, 2026
sjpfenninger
approved these changes
Apr 30, 2026
sjpfenninger
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me. Also, I know it's not part of this PR, but a comment on the README structure: it looks good, though I would add a Quickstart section early on in all module docs, with the idea that this provides one or two quick/easy one-liners to run the workflow without wiring it up as a module. E.g. something like:
## Quickstart
Run this standalone with the configuration in `config/config.yaml` to produce both the parquet output file and a PNG plot of the shapes:
`pixi run snakemake --cores 2 results/shapes.parquet results/shapes.png`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51, #54, #50
Summary of changes in this pull request
Reviewer checklist
pipdependencies in the module's environment files (workflow/envs/).pathvars(e.g.,<results>) in their inputs and outputs.pre-commit.citests pass.INTERFACE.yamlmentions all relevantpathvarsandwildcards.README.mddescribes how to use the module and has the necessary citations.