Update: MCP architecture deepening#34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue
MCP Registry install behavior should stay product-compatible while the new Registry/config/status implementation moves behind deeper MCP-domain modules. Add to MCPs must continue storing registry-derived managed MCPs and probing availability, including stdio execution, while stale historical MCP terminology stays removed.
Fix
Persisted Registry install intent in managed manifest v6, added managed state assembly for installConfigStatus/mcpStatus/compatibility fields, moved harness writes into a transaction module, moved observed config choice ranking and validation into a backend domain module, collapsed frontend enable/config orchestration into one workflow hook, split Registry support policy from catalog presentation, and added a repository-wide stale-term guard.
Changed files
skill_manager/application/mcp/install_intent.py
skill_manager/application/mcp/managed_state.py
skill_manager/application/mcp/harness_application.py
skill_manager/application/mcp/config_choice.py
skill_manager/application/mcp/marketplace/support_policy.py
skill_manager/application/mcp/install_resolver.py
skill_manager/application/mcp/install_state.py
skill_manager/application/mcp/mutations.py
skill_manager/application/mcp/query.py
skill_manager/application/mcp/store.py
skill_manager/application/mcp/marketplace/catalog.py
skill_manager/api/schemas/mcp.py
frontend/src/features/mcp
frontend/src/api
tests/integration/test_mcp_routes.py
tests/unit/test_mcp_config_choice.py
tests/unit/test_mcp_harness_application.py
tests/unit/test_mcp_historical_terms.py
tests/unit/test_mcp_install_intent.py
tests/unit/test_mcp_install_resolver.py
tests/unit/test_mcp_registry_support_policy.py
tests/unit/test_mcp_store.py
Validation
git diff --check
git diff --cached --check
npm run typecheck
npm run codegen:check
npm test
scripts/test_backend.sh
git grep stale-term scans for historical MCP references
Reviewer: @SI-RUI-ZHANG