Update: MCP registry install config flow#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue
Add to MCPs should store registry-derived managed MCPs and immediately probe availability, including stdio execution, while enable/config/status behavior should be structurally clean and safe across repeated harness enables. The branch should also remove historical Smithery/source-harness/deferred-install references repo-wide.
Fix
Implemented install config status for managed marketplace MCPs, expanded public MCP status to include needs_config and unchecked, moved enable config resolution into MCP-domain helpers, fixed enable-all manifest persistence, updated frontend gating/status UI, and added backend/frontend coverage.
Follow-up cleanup
Removed repository-wide historical literals for Smithery, sourceHarness/source harness, and deferred install wording. Renamed the MCP adoption/reconcile API field from sourceHarness to observedHarness, updated docs/assets/tests/generated API types, and removed the named provider block so Registry install support is generic.
Changed files
skill_manager/application/mcp/install_state.py
skill_manager/application/mcp/install_resolver.py
skill_manager/application/mcp/mutations.py
skill_manager/application/mcp/query.py
skill_manager/api/schemas/mcp.py
skill_manager/api/routers/mcp.py
frontend/src/features/mcp
frontend/src/features/marketplace
frontend/src/app/capability-registry/overview.ts
frontend/src/api
README.md
assets/skill-manager-mcp-translation.svg
tests/integration/test_mcp_routes.py
tests/unit
Reviewer: @SI-RUI-ZHANG