Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughCHARACTER_DATA 설정 객체를 제거하고 타입 제약을 완화합니다. 이미지 참조 방식을 imageBigUrl 필드로 통일하고, 캐릭터 UI 컴포넌트의 스타일을 통합한 후, 공유 페이지의 다운로드 메커니즘을 DOM 캡처에서 직접 이미지 fetch로 변경합니다. ChangesCharacter 데이터 참조 마이그레이션
Possibly Related PRs
Suggested Labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📝 관련 이슈 |
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/pages/characterShare/CharacterSharePage.styles.ts (2)
50-54: 💤 Low value
CharacterImage스타일 컴포넌트가 중복 정의되어 있습니다.
src/features/character-management/ui/CharacterBottomSheet/index.styles.ts에도CharacterImage가 존재하지만 스타일이 다릅니다:
- BottomSheet:
max-width: 100%; max-height: 100%; object-fit: contain;- SharePage:
width: 100%; max-width: 19.375rem; height: auto;사용 컨텍스트가 다르다면 현재 구조가 적절할 수 있으나, 향후 변경 시 양쪽을 모두 수정해야 하는 점을 유의하시기 바랍니다.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/characterShare/CharacterSharePage.styles.ts` around lines 50 - 54, There are two distinct styled components both named CharacterImage (used in CharacterSharePage and CharacterBottomSheet) which risks confusion and duplicate edits; either consolidate them into one shared, configurable component (e.g., a single CharacterImage that accepts props like maxWidth, maxHeight, and objectFit) and import it into both CharacterSharePage and CharacterBottomSheet, or rename the two implementations to distinct names (e.g., CharacterImageShare and CharacterImageBottomSheet) and update their imports; update references where CharacterImage is used so the correct variant or prop-driven styling is applied.
26-26: ⚡ Quick win패딩 값 일부는 토큰으로 치환 가능하지만(0.5rem), 2.5rem은 현재 토큰으로 대체 불가
src/pages/characterShare/CharacterSharePage.styles.ts의CharacterCardContainerpadding: 0.5rem 2.5rem;중0.5rem(8px)은getToken('padding.3')로 대체 가능합니다.
다만2.5rem(40px)은 semantic spacing 토큰padding.1~padding.7에 대응 값이 없어(padding.8+없음)getToken('padding.*')로 치환하기 어렵습니다.padding: 0.5rem 2.5rem;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/characterShare/CharacterSharePage.styles.ts` at line 26, CharacterCardContainer's padding uses hardcoded values "0.5rem 2.5rem"; replace the 0.5rem with the token getToken('padding.3') and avoid the raw 2.5rem by adding a new semantic spacing token (e.g., padding.8 = 2.5rem) to your design tokens and then use getToken('padding.8') in CharacterCardContainer so both horizontal and vertical paddings are expressed via tokens.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/characterShare/CharacterSharePage.tsx`:
- Line 21: The call saveAs(blob, `${data.name}.png`) may fail if data.name
contains invalid filesystem characters; update the code around saveAs to
sanitize data.name before building the filename (e.g., create a helper
sanitizeFileName(name) that strips or replaces characters like / \ : * ? " < > |
and trims whitespace), ensure the sanitized result is not empty (use a safe
fallback like "share"), and then call saveAs(blob, `${sanitizedName}.png`) so
the saved filename is always filesystem-safe.
---
Nitpick comments:
In `@src/pages/characterShare/CharacterSharePage.styles.ts`:
- Around line 50-54: There are two distinct styled components both named
CharacterImage (used in CharacterSharePage and CharacterBottomSheet) which risks
confusion and duplicate edits; either consolidate them into one shared,
configurable component (e.g., a single CharacterImage that accepts props like
maxWidth, maxHeight, and objectFit) and import it into both CharacterSharePage
and CharacterBottomSheet, or rename the two implementations to distinct names
(e.g., CharacterImageShare and CharacterImageBottomSheet) and update their
imports; update references where CharacterImage is used so the correct variant
or prop-driven styling is applied.
- Line 26: CharacterCardContainer's padding uses hardcoded values "0.5rem
2.5rem"; replace the 0.5rem with the token getToken('padding.3') and avoid the
raw 2.5rem by adding a new semantic spacing token (e.g., padding.8 = 2.5rem) to
your design tokens and then use getToken('padding.8') in CharacterCardContainer
so both horizontal and vertical paddings are expressed via tokens.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f7ee4649-9417-410d-a898-542c8f6914b7
📒 Files selected for processing (7)
src/entities/character/config/character.tssrc/entities/character/model/character.type.tssrc/features/character-management/ui/CharacterBottomSheet/index.styles.tssrc/features/character-management/ui/CharacterBottomSheet/index.tsxsrc/features/character-management/ui/CharacterItem/index.tsxsrc/pages/characterShare/CharacterSharePage.styles.tssrc/pages/characterShare/CharacterSharePage.tsx
💤 Files with no reviewable changes (1)
- src/entities/character/config/character.ts
Deploying moddo-frontend with
|
| Latest commit: |
34f58b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c20a5328.moddo-frontend.pages.dev |
| Branch Preview URL: | https://fix-md-23.moddo-frontend.pages.dev |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
이미지 저장 안되는 이슈는 일단 현재 배포버전에서도 발생중인 문제라서... 우선 해당 작업은 개발 브랜치에 머지하고 별도 브랜치에서 문제 수정하도록 하겠습니다!!! |
1 participant
💻 작업 내용
이전
변경 후
✅ 테스트 리스트
📸 스크린샷
👻 리뷰 요구사항
이미지 다운로드가 CORS 에러로 인해서 동작하지 않습니다...
AllowedOrigins 설정을 했음에도 불구하고 안되고 있어서 원인을 찾아봐야 하는 상황입니다!!
(코드래빗 리뷰를 위해서 일단 열어두고, 이 문제 해결한 뒤에 머지하겠습니다 .. ㅠ)
Summary by CodeRabbit