Fix race condition in concurrent task execution - #9
Open
singularitycurse26-svg wants to merge 1 commit into
Open
Fix race condition in concurrent task execution#9singularitycurse26-svg wants to merge 1 commit into
singularitycurse26-svg wants to merge 1 commit into
Conversation
5 tasks
|
👀 We've notified the reward creators here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1
Changes
workspace/task/runner.gotask.State,task.Err,task.History,task.StartedAt,task.FinishedAt) with thread-safe setter methods (SetState,SetErr,SetStartedAt,SetFinishedAt)task.mu.Lock()/Unlock()blocks in favor of encapsulated methodsSetStatemethod which handles locking internallyworkspace/task/task.goSetStartedAtandSetFinishedAtmethods for thread-safe write access to time fieldsworkspace/task/runner_test.goTestRunner_Runto useGetState()instead of directt1.Statefield access (race condition in test itself)TestRunner_Run_StressWithCancel— 100 concurrent tasks with mid-execution cancellation, concurrent metadata reads/writes, and state checks. Verifiesgo test -racepasses cleanly.Acceptance Criteria Met
go test -race ./...passes with zero data race warningsSetStatewith mutex/claim #1