Fix task state races during concurrent runner execution - #11
Open
Obvidio wants to merge 1 commit into
Open
Conversation
Author
|
Payment account is now connected in Opire. This PR remains ready for review; the local Go test results and concurrency fix details are included in the PR description. Please let me know if any maintainer changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes direct task state mutation from Runner.Run and routes state transitions through Task methods that hold the task mutex while updating related fields.
Changes:
Testing:
Why:
Concurrent readers already use Task getters protected by RWMutex. Keeping all runner writes behind Task methods makes the concurrency contract explicit and keeps state, error, timestamp, and history updates atomic under the same lock.