Skip to content

Compatibility with Dart 2.10.#217

Open
trygvis wants to merge 14 commits into
mmcc007:masterfrom
trygvis:master
Open

Compatibility with Dart 2.10.#217
trygvis wants to merge 14 commits into
mmcc007:masterfrom
trygvis:master

Conversation

@trygvis

@trygvis trygvis commented Oct 15, 2020

Copy link
Copy Markdown

This depends on mmcc007/tool_base#2, mmcc007/tool_mobile#1 and mmcc007/fake_process_manager#1.

These changes has been done as a part of getting screenshots to work with Dart 2.10. The new screenshots work in the same way as earlier builds for my app.

@trygvis

trygvis commented Oct 15, 2020

Copy link
Copy Markdown
Author

This fixes #215.

@mazzonem

mazzonem commented Mar 4, 2021

Copy link
Copy Markdown

@mmcc007 Would you be happy to merge this? #215 seems to be a fairly large issue now that Flutter 2.0 is in Stable.

Thanks in advance 🙏

@clangenb

Copy link
Copy Markdown

I would also be happy if this is merged.

I think screenshots would be a valuable tool, but the unresponsiveness worries me a bit.

@felixwortmann

Copy link
Copy Markdown

Is anyone willing to publish a working fork of screenshots if there is no activity soon?

I think this is a great project and it would help a lot of developers.

@M123-dev

Copy link
Copy Markdown

Ping @mmcc007

@teolemon

Copy link
Copy Markdown

@trygvis can you try solving the unit tests in the PR so that it's an easier "sell" to merge the PR ? I'm going to try reaching out to @mmcc007

Necessary to replace the 'resources' package.
Fixing many small bugs, lots of null pointers and badly converted
code.
Don't hang forever on devices where we're unable to change the locale.
@trygvis

trygvis commented Oct 28, 2021

Copy link
Copy Markdown
Author

@teolemon I've done some work on trying to get it up to date with the latest dart/flutter releases but it is a fair bit of work. Any help and testing would be appreciated. I've worked out a good number of bugs, but I'm sure there are more remaining.

All my work is done on my fork for now.

Some code is now working, but the response from the Flutter daemon in
startEmulator() doesn't include the emulatorId (emulator-5554) so we
don't know how to talk to adb.
@teolemon

teolemon commented Jan 9, 2022

Copy link
Copy Markdown

Thank you very much @trygvis 🎉
@mmcc007 does not seem to be reacting. We might opt for a new repository, and publish to pub.dev ?

@M123-dev

M123-dev commented Jan 9, 2022

Copy link
Copy Markdown

Sounds good, but this seems to be a very essential plugin, depending on how much time you @trygvis want to invest here you could also ask fluttercommunity if you could transfer your repository over there. Just as an idea

@DeanPack

DeanPack commented Apr 1, 2022

Copy link
Copy Markdown

Found this thread here about bringing it up to date. Can I get an update on when this could be useable?

@alexxgarci

Copy link
Copy Markdown

Found this thread here about bringing it up to date. Can I get an update on when this could be useable?

Any other package to do the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants