Fix track walk interaction and data loading - #35
Merged
Conversation
CI failure on this branch was a test-collection error:
tests/features/coaching/conftest.py:37: in <module>
from tests.conftest import _start_session, _frames_to_payload
E ModuleNotFoundError: No module named 'tests'
`uv run pytest` doesn't automatically put the repo root on sys.path
(unlike running pytest from the rootdir directly), so the `tests.*`
package isn't importable during collection. Setting pythonpath in
[tool.pytest.ini_options] makes the rootdir explicit for all runners.
Verified locally: `pytest --collect-only` now finds 155 tests instead
of erroring out at collection.
can_reader.py imports `yaml` to load car configs but pyyaml was not in the base dependencies — neither the main `dependencies` list nor any extra. Tests that exercise the CAN reader path (8 of them in this PR) fail in CI with: ModuleNotFoundError: No module named 'yaml' ERROR pitwall.can_reader:236 car config load failed uv sync will re-resolve uv.lock automatically when pyproject.toml changes, so no lockfile delta is committed here — CI's `uv sync` will pick up the new dep on the next run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification