Drop support for Optimization v3 - #227
Closed
sethaxen wants to merge 5 commits into
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 83.16% 83.16%
=======================================
Files 13 13
Lines 588 588
=======================================
Hits 489 489
Misses 99 99 ☔ View full report in Codecov by Sentry. |
Member
Author
|
In #218 I was able to find a workaround to keep support for Optimization >= v3.24. Since bumping to a lower bound of v4 causes so many version restrictions across the board, that seems safer for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor for
OptimizationCachechanged between Optimization v3 and v4. #218 constructs such a cache, so this PR drops support for Optimization v3. To ensure our compat lower bounds are mutually compatible (tested by the downgrade versions of actions), this PR also bumps the lower bounds for many package, test, and docs dependencies.