Fix CUDA RMSNorm small-row dispatch#3792
Open
dhiltgen wants to merge 2 commits into
Open
Conversation
CUDA RMSNorm used a launch shape that packed multiple rows into one block even when each row required more than one reduction group. BlockBroadcastReduce is block-wide, so those rows mixed partial reductions and produced incorrect results for small dimensions such as fp32 D=256 and bf16/fp16 D=512. Fix the affected dispatch case by launching one row per block when two reduction groups are needed. Add CUDA regression coverage for forward and VJP fast RMSNorm on the affected small multi-row shapes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
CUDA RMSNorm used a launch shape that packed multiple rows into one block even when each row required more than one reduction group. BlockBroadcastReduce is block-wide, so those rows mixed partial reductions and produced incorrect results for small dimensions such as fp32 D=256 and bf16/fp16 D=512.
Fix the affected dispatch case by launching one row per block when two reduction groups are needed. Add CUDA regression coverage for forward and VJP fast RMSNorm on the affected small multi-row shapes.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes