[Feature] Additional padding modes

[sidtuladhar]

Proposed changes

Hi team, this PR adds symmetric and reflect padding modes. It addresses issue #2155

Checklist

Put an x in the boxes that apply.

• I have read the CONTRIBUTING document
• I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
• I have added tests that prove my fix is effective or that my feature works
• I have updated the necessary documentation (if needed)

[sidtuladhar]

Hi, could I get a review on this, thanks! @awni

[sidtuladhar]

Hey there @awni @zcbenz, bumping this, would appreciate if I could get some feedback on this PR, thanks!

[zcbenz]

Sorry for the late review, do you mind rebasing this on main branch so we can run tests? The code basically looks good to me.

[sidtuladhar]

Done! @zcbenz

[zcbenz]

The tests are failing.

[sidtuladhar]

should be fixed now

[zcbenz]

The CPP tests are still failing, the python tests are passing so I think there is no problem with the API implementation, we only need to get the test case right.

[sidtuladhar]

Gotcha, cpp tests should pass now

[zcbenz]

Looks good to me, thanks!

[zcbenz]

Sorry for the long time, the implementation is a bit over complicated and we have been hesitating on merging, and since there is a more concise implementation in #3608 I'm going to close this in favor of it. Please let us know if #3608 is missing anything.