Decompile small game stubs#37
Closed
jefemagril wants to merge 13 commits into
Closed
Conversation
mkst
reviewed
Jun 25, 2026
|
|
||
| #pragma GLOBAL_ASM("asm/nonmatchings/game_161520/func_15137E10.s") | ||
| s32 func_15137E10(void *arg0) { | ||
| *(f32 *)((u8 *)arg0 + 0x74) = ((func_150ADA68() * 50.0f) + 580.0f) * D_800A4828; |
Owner
There was a problem hiding this comment.
Did you use AI for this? We shouldn't be doing pointer math.
Author
There was a problem hiding this comment.
Yes, and also I'm new to this decomp scene so I apologize. In this case, it's probably some yet-unknown struct? I went through and tried to make it more readable throughout and in cases where I couldn't (for example, maybe missing outer declarations context), I left them in commented out form.
…d of void pointers for better type safety
…ructs instead of void pointers, enhancing type safety and code clarity.
…ty by replacing void pointers with specific structs, and update function implementations to match new signatures.
Owner
|
I'm closing this as it doesn't add any value. You would have been better off decompiling these functions by hand. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gamesection stubs fromGLOBAL_ASMto matching C.Verification
docker run --rm -v "$PWD":/conker -w /conker/conker conker bash -lc 'make --jobs'docker run --rm -v "$PWD":/conker -w /conker conker bash -lc 'make -C conker replace && make --jobs'docker run --rm -v "$PWD":/conker -w /conker/conker conker bash -lc 'make progress'Final ROM rebuild passed with
build/conker.us.z64: OK.