Skip to content

Fix IMAP4WithTimeout compatibility with Python 3.14 #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
736-c41-2c1-e464fc974 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix IMAP4WithTimeout compatibility with Python 3.14 #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions imapclient/imap4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,7 @@
class IMAP4WithTimeout(imaplib.IMAP4):
def __init__(self, address: str, port: int, timeout: Optional[float]) -> None:
self._timeout = timeout
imaplib.IMAP4.__init__(self, address, port)

def open(
self, host: str = "", port: int = 143, timeout: Optional[float] = None
) -> None:
# This is overridden to make it consistent across Python versions.
self.host = host
self.port = port
self.sock = self._create_socket(timeout)
self.file = self.sock.makefile("rb")
imaplib.IMAP4.__init__(self, address, port, timeout=timeout)

def _create_socket(self, timeout: Optional[float] = None) -> socket.socket:
return socket.create_connection(
Expand Down