chore(analytics): document that screenName must be non-empty in trackScreenView/trackScreenLeave - #446
Merged
rahul-mixpanel merged 3 commits intoJul 29, 2026
Conversation
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| index.js | Adds documentation for the existing screen-name validation behavior. |
| index.d.ts | Adds matching API documentation to the TypeScript declarations. |
Reviews (2): Last reviewed commit: "Revert "chore: run prettier on index.js ..." | Re-trigger Greptile
tylerjroach
previously approved these changes
Jul 28, 2026
This reverts commit ee73af6.
tylerjroach
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
screenNameparam fortrackScreenViewandtrackScreenLeaveinindex.jsstating it must be non-empty and the event is silently dropped if empty/whitespace-only.index.d.tsfor the same methods.Test plan
SDK-142