Conversation
- Replace java -jar with proper -classpath including Ghidra Framework/Features/Processors JARs - Use --bind instead of --host (server CLI flag mismatch) - Export GHIDRA_MCP_AUTH_TOKEN env var (server reads from env, no --token flag) - Redirect log to /tmp instead of /var/log (container runs as non-root) - Add 30s health-check readiness loop with auth header - Make bind address configurable via GHIDRA_MCP_HOST
- Single stdio entry point for all toolbox MCP servers - Namespaced tool names (r2__*, ghidra__*, shell__*, angr__*) - Graceful degradation — failed children don't block gateway - Fix mcp.Server import (mcp.server module, not top-level) - Add angr child (python3 -m angr.mcp)
- binary-triage (haiku): fast radare2 + shell first-look - ghidra-importer (sonnet): import + auto-analyze + load-ghidra.sh fallback - ghidra-analyst (sonnet): static RE — decompile, xrefs, rename, annotate - ghidra-debugger (sonnet): dynamic analysis — breakpoints, tracing, memory watch - re-orchestrator (opus): full pipeline triage → import → static → dynamic → report - CLAUDE.md: agent reference + quickstart for repo newcomers
…architecture - Add Ghidra tool availability section (static vs instance-scoped, lifecycle diagram) - Add agent system documentation with usage examples - Add angr to server catalog and architecture diagram - Update project structure tree with .claude/agents/ - Document load-ghidra.sh as primary CLI import path - Preserve all existing CLI tools reference and MCP config docs
- Replace 3 individual MCP server entries with single toolbox gateway - Remove .claude/ from .gitignore so agents/ and settings.json ship with repo - Add .claude/settings.json enabling project MCP servers by default
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1798eefd24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Dockerfile: drop COPY configs/ (configs/base.json was deleted, empty dir fails on fresh checkout) - Gateway: mark ghidra child as dynamic=True, refresh tool list after import_file/connect_instance so instance-scoped tools (decompile_function, list_functions, debugger_*, etc.) appear without restarting the MCP process - Add asyncio.Lock around _tools dict for concurrent list_tools/call_tool safety
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.