Make SC2, WoW, and Profile related APIs all independent packages - #8
Open
nmccrory wants to merge 20 commits into
Open
Make SC2, WoW, and Profile related APIs all independent packages#8nmccrory wants to merge 20 commits into
nmccrory wants to merge 20 commits into
Conversation
Merging dev and master
Profile, SC2, and WoW have all been moved into their own packages.
removed unused imports inside of client.go
Cleaning up workspace to begin development from nmccrory/go-bnet fork
…lso noticed a mistake in the client.go file of the go-bnet package... There was a need for a NewClient method for use in the client_test setup().
Created a close to working service for profiles in the sc2 package. A…
…d the Matches() method to retrieve a Starcraft 2 profile's match history.
…rom github.com/mitchellh/go-bnet/.. to make merging easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that there were a few errors in the last PR that I opened. Specifically a file structure mistake that caused a package loop and the exclusion of a
NewClient()method in the project's mainclient.gofile.In terms of additions, the
go-bnet/sc2package can now retrieve a profile's match history with a call tosc2.client.Profile().Matches(:id, :region, :name). I also updated.travis.ymlto use Go 1.8.Thanks and apologies for mistakes in the last PR!