Solve memoverride.cpp failing to override all versions of new/new[]/delete/delete[] - #4
Open
RaphaelIT7 wants to merge 2 commits into
Open
Solve memoverride.cpp failing to override all versions of new/new[]/delete/delete[]#4RaphaelIT7 wants to merge 2 commits into
memoverride.cpp failing to override all versions of new/new[]/delete/delete[]#4RaphaelIT7 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fun one - Solves misyltoad/VPhysics-Jolt#259
Example of this issue:
JPH::Ref<JPH::CharacterSettings> settings = new JPH::CharacterSettings();in this line it internally allocates the memory using
g_pMemAlloc->Allocsince memoverride overwrotenewNow, when the
JPH::Refleaves the scope / gets released, it callsdelete static_cast<const T *>(this);The issue with that is, that in C++17 & higher there is
__cpp_aligned_newwhich introduces more versions ofnew,new[],delete,delete[]which are all not accounted for leaving them in a weird state where they might call the memoverride version - or they call the C++ standart version which ends up trying to delete the memory as aligned memory.
And for this example case it tries to call
void operator delete( void* pMem, size_t sz, std::align_val_t align ) noexceptwhich was not overwritten.