Skip to content

patch- decouple svg.js from app.js and have it as a separate file#45

Open
dkdrk wants to merge 1 commit into
minutebase:masterfrom
dkdrk:patch_decouple_from_appjs
Open

patch- decouple svg.js from app.js and have it as a separate file#45
dkdrk wants to merge 1 commit into
minutebase:masterfrom
dkdrk:patch_decouple_from_appjs

Conversation

@dkdrk

@dkdrk dkdrk commented Oct 10, 2017

Copy link
Copy Markdown

No description provided.

@rlivsey

rlivsey commented Oct 10, 2017

Copy link
Copy Markdown
Member

👍 I like the direction this is going.

Would be great if it didn't use the Ember global, this is going away in future ember releases and don't think we should hang data off it.

Maybe should just be a global constant like APP_SVGS, or wrap it in define so that it can be imported into the app vs a global?

Eg similar pattern to shims like:

(function() {
  function svgModule() {
    'use strict';
    const SVGS = {} // the SVG data
    return { 'default': SVGS };
  }
  define('svgs', [], svgModule);
})();

@buschtoens

Copy link
Copy Markdown
Collaborator

Referencing buschtoens/broccoli-flatiron#1

@dkdrk dkdrk force-pushed the patch_decouple_from_appjs branch from 4320399 to dd64bba Compare October 10, 2017 12:00
@dkdrk dkdrk force-pushed the patch_decouple_from_appjs branch from db81d2e to ae513e7 Compare November 23, 2017 05:46
@dkdrk

dkdrk commented Nov 23, 2017

Copy link
Copy Markdown
Author

any other changes to be done @rlivsey ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants