fix: trim all overflow messages in a single summarizer pass - #211
Merged
plfavreau merged 1 commit intoJul 9, 2026
Merged
Conversation
The `return` was indented inside the `for` loop, causing the node to exit after the first iteration and remove at most one message per pass even when history was several messages over MAX_MESSAGES_IN_HISTORY. Move `return` outside the loop so every overflow candidate is collected before the state update is emitted. Fixes minitap-ai#210
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
plfavreau
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
return await state.asanitize_update(...)was indented inside theforloop that scans overflow candidates, so the node returned after the very first iteration and removed at most one message per pass — even when history was several messages overMAX_MESSAGES_IN_HISTORY.Moving the
returnoutside the loop lets the loop collect every overflow candidate before the state update is emitted, so the history is trimmed back to the configured cap in a single pass.Fixes #210
Changes
minitap/mobile_use/agents/summarizer/summarizer.py: dedentreturn await state.asanitize_update(...)to sit outside theforloop