Skip to content

fix: wrap long lines in idb_client.py to pass ruff format check - #206

Merged
plfavreau merged 1 commit into
minitap-ai:mainfrom
citizen204:fix-204-ruff-line-length-idb-client
Jun 23, 2026
Merged

fix: wrap long lines in idb_client.py to pass ruff format check#206
plfavreau merged 1 commit into
minitap-ai:mainfrom
citizen204:fix-204-ruff-line-length-idb-client

Conversation

@citizen204

@citizen204 citizen204 commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary

Two lines in minitap/mobile_use/clients/idb_client.py exceed the 100-character line length limit enforced by ruff format --check:

  • Line 388 — a 137-char comment condensed from a multi-line comment in commit 887fcec
  • Line 390 — a 101-char re.match(...) call pushed over the limit when |Localized was added to the regex in commit 9319672

This PR fixes both by:

  • Splitting the long comment across two lines
  • Wrapping the re.match call with standard ruff-style argument-per-line formatting

Fixes #204

Changes

  • minitap/mobile_use/clients/idb_client.py: wrap comment at line 388 and break re.match call at line 390 to stay under 100 chars

Summary by CodeRabbit

  • Refactor
    • Improved code formatting and readability in app matching logic for better maintainability.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c197c01a-6ca5-44a4-b21b-be2015161440

📥 Commits

Reviewing files that changed from the base of the PR and between 887fcec and 4a1c556.

📒 Files selected for processing (1)
  • minitap/mobile_use/clients/idb_client.py

📝 Walkthrough

Walkthrough

In IdbClientWrapper.app_current, the re.match call for CFBundle(?:Display|Localized)?Name is reformatted into a multi-line form to comply with the project's 100-character line length limit. No logic, regex pattern, or field extraction behavior changes.

Changes

Ruff formatting fix in idb_client.py

Layer / File(s) Summary
Multi-line re.match formatting in app_current
minitap/mobile_use/clients/idb_client.py
The re.match call for `CFBundle(?:Display

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • minitap-ai/mobile-use#202: Modifies the same IdbClientWrapper.app_current() display-name-to-bundle-id matching logic in idb_client.py, introducing the |Localized variant that caused the line to exceed the length limit fixed here.

Suggested reviewers

  • plfavreau

Poem

🐇 A line grew too long, past one hundred chars wide,
So I wrapped it up neatly and tucked it inside.
The linter now passes, no red in the log,
Just tidy clean Python, no ruff in the fog!
✨ Formatting wins, says this little code hog.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: wrapping long lines in idb_client.py to fix ruff format violations.
Linked Issues check ✅ Passed The PR directly addresses all requirements from issue #204: wrapping two lines (388 and 390) to comply with the 100-character limit.
Out of Scope Changes check ✅ Passed All changes are directly scoped to formatting issues in idb_client.py as specified in issue #204; no out-of-scope modifications are present.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@plfavreau plfavreau assigned plfavreau and citizen204 and unassigned plfavreau Jun 23, 2026
@plfavreau
plfavreau merged commit 7f8346b into minitap-ai:main Jun 23, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI: ruff format --check fails on idb_client.py (line exceeds 100-char limit)

2 participants