Handle generator exhaustion#248
Draft
sneakers-the-rat wants to merge 3 commits into
Draft
Conversation
This reverts commit 2305552e62bf057fc43e1ceaed3a396ca6c61a76.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A draft of fixing #147 - but we should not merge this, in working on this i realized that our stopping logic in general needs some work, related to #206 as well.
So this was part of the "see if fable can actually do stuff" test run, the initial commit is its attempt and called it good. clearly that is inadequate.
mine adds handling exhaustion as an event but is similarly hacky - the things we need are
inits #247 - better control over initialization condition, we need a general way to shut it down and exist from whatever run is happening.opening this up as a draft, but we should fix the other things first, and i'll need to think about how we want to handle this in the scheduler.
📚 Documentation preview 📚: https://noob--248.org.readthedocs.build/en/248/