Support contextmanagers as assets#246
Open
sneakers-the-rat wants to merge 7 commits into
Open
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #110 but doesn't close it.
This is the first half of the issue, allowing contextmanagers as assets, but it does not address the main point of the issue, which is about providing some kind of "middleware" that can wrap around nodes for repeated operations across nodes.
This PR just makes it possible to use contextmanagers as assets, simple as.
however during testing, discovered a few bugs in how assets were handling both in the base runner and the async runner:
statewas flawed to allow that to happen - we should only initialize node-scoped assets when they are directly depended on by the node.These were discovered here because the test for the contextmanager included init/deinit counts, which were off in the flawed code. the tests here do not test global counts of init/deinit, just per asset instance, so further testing to constrain the behavior would be good here.
📚 Documentation preview 📚: https://noob--246.org.readthedocs.build/en/246/