Allow multiple assets to be updated from same node#244
Open
sneakers-the-rat wants to merge 1 commit into
Open
Conversation
fc85a9c to
ad058b1
Compare
Merging this PR will degrade performance by 13.55%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| 👁 | Simulation | test_kitchen_sink_process[ZMQRunner-testing-kitchen-sink] |
2.8 ms | 3.2 ms | -13.55% |
Comparing issue-200 (ad058b1) with main (5c236d7)
Footnotes
-
8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Collaborator
Author
|
perf regression is fake news, genuinely hate that thing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #200
Previously, it was only possible to have one asset dependency mapping per node. However nodes can emit multiple signals, and the same signal might be used to update multiple assets (not exactly sure when this would be useful, but it's a logical implication of the spec and should work).
Simple enough change, using a nested dict to keep the external lookups quick (O(1) is node relevant to the update, as used in the zmq runner) - alternative considered was using
NodeSignal()as the key but that requires allocating a tuple on every lookup.added
dependency_assetscached prop to get the set of assets with dependencies since thedependenciesdict is no longer 1:1 count of assets in the value field.📚 Documentation preview 📚: https://noob--244.org.readthedocs.build/en/244/