Changed stop criterion to just FWHM change per iteration #166
Draft
kaghi wants to merge 1 commit into
Draft
Conversation
…ith some issues with spike inference quality. Instead, testing FWHM alone as a stop criterion leads to consistence convergence of CaDecon around 7–12 iters with same or greater spike inference quality and tighter variance across multiple seeds.
Contributor
|
I think the assumption we have to be backing here is all relevant metrics should trend towards some stable asymptotic level. Given that, if time-to-peak over iterations is not trending to a stable solution, then there is an issue with our assumptions and just excluding it from the convergence metric likely isn't the correct option. I think FWHM only tells part of the story for the kernel shape... where peak tell the remaining part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
max(peak-time, FWHM) shows inconsistences in iterations it stops at with some issues with spike inference quality. Instead, testing FWHM alone as a stop criterion leads to consistence convergence of CaDecon around 7–12 iters with same or greater spike inference quality and tighter variance across multiple seeds.