Skip to content

Fix local offline skins in multiplayer servers - #13

Open
minetwice wants to merge 37 commits into
creators-lore-advancement-loop-6630573669648401262from
fix-multiplayer-local-skins-18143932138295815932
Open

Fix local offline skins in multiplayer servers#13
minetwice wants to merge 37 commits into
creators-lore-advancement-loop-6630573669648401262from
fix-multiplayer-local-skins-18143932138295815932

Conversation

@minetwice

@minetwice minetwice commented Jul 25, 2026

Copy link
Copy Markdown
Owner

User description

Introduced LocalSkinServer to serve local offline skins on multiplayer servers via authlib-injector, and fixed active-instance folder synchronization. Also addressed code review concerns regarding file-exists checks and shared preferences persistence.

PR created automatically by Jules for task 18143932138295815932 started by @minetwice


CodeAnt-AI Description

Replace Ely.by authentication with CraftynMC and keep custom skins visible in multiplayer

What Changed

  • Replaces Ely.by with CraftynMC login and registration, including live username availability checks and staged authentication feedback
  • Downloads CraftynMC skins, supports classic and slim player models, and refreshes skins when accounts are reused
  • Makes local and CraftynMC skins available on multiplayer servers through a built-in skin service, while forwarding other players’ skins to Mojang
  • Synchronizes the selected skin with the main game folder and active instance before launch
  • Limits account selection to Microsoft, CraftynMC, and Local accounts

Impact

✅ Local skins remain visible in multiplayer
✅ CraftynMC accounts can sign in and register
✅ Custom skins stay synchronized across game instances

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

… and authlib-injector injection

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codeant-ai

codeant-ai Bot commented Jul 25, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Incremental review completed a03db6b Jul 31, 2026 · 08:04 08:05
✅ Incremental review completed 3b17a1e Jul 31, 2026 · 02:13 02:14
✅ Incremental review completed be19246 Jul 30, 2026 · 20:20 20:20
✅ Incremental review completed a29d3aa Jul 30, 2026 · 18:55 18:55
✅ Incremental review completed 3bcff53 Jul 30, 2026 · 16:59 16:59

google-labs-jules Bot and others added 3 commits July 25, 2026 18:49
…nistic Type 3 UUID matching in LocalSkinServer

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
…branding for the launcher

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
…r to multiplayer servers via authlib-injector and LocalSkinServer

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
@codeant-ai codeant-ai Bot added the size:XL This PR changes 500-999 lines, ignoring generated files label Jul 26, 2026
google-labs-jules Bot and others added 3 commits July 26, 2026 18:00
…ic download and synchronization into the launcher and game client

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
… Local logins, and style with premium glass theme

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
@codeant-ai codeant-ai Bot added size:XL This PR changes 500-999 lines, ignoring generated files and removed size:XL This PR changes 500-999 lines, ignoring generated files labels Jul 27, 2026
@codeant-ai codeant-ai Bot added size:XL This PR changes 500-999 lines, ignoring generated files and removed size:XL This PR changes 500-999 lines, ignoring generated files labels Jul 27, 2026
minetwice and others added 3 commits July 27, 2026 06:53
…m UI, skin sync, and server local proxy loader

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
…ic skin synchronization

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
@codeant-ai codeant-ai Bot removed the size:XL This PR changes 500-999 lines, ignoring generated files label Jul 28, 2026
@codeant-ai codeant-ai Bot added size:XL This PR changes 500-999 lines, ignoring generated files and removed size:XXL This PR changes 1000+ lines, ignoring generated files labels Jul 30, 2026
minetwice and others added 5 commits July 30, 2026 13:38
Refactor CraftynLoginFragment to use MineEditText for username and password input, removing WebView and related logic.
Updated CraftynMC authentication URLs to fix skin display issues.
This class models the authentication response structure from the server.
…er, live username checks, and 3-stage progress HUD

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
@codeant-ai codeant-ai Bot added size:XXL This PR changes 1000+ lines, ignoring generated files and removed size:XL This PR changes 500-999 lines, ignoring generated files labels Jul 30, 2026
…itelisted minecraft.net domain intercepted by authlib-injector

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
@codeant-ai codeant-ai Bot added size:XXL This PR changes 1000+ lines, ignoring generated files and removed size:XXL This PR changes 1000+ lines, ignoring generated files labels Jul 30, 2026
Ensure that LocalSkinServer creates valid 64-character SHA-256 hex
hashes for offline/local player profiles to pass strict client-side
texture URL validations. Added automatic skin proxying to route texture
requests to textures.minecraft.net for other online players when using authlib-injector.

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
@codeant-ai codeant-ai Bot added size:XXL This PR changes 1000+ lines, ignoring generated files and removed size:XXL This PR changes 1000+ lines, ignoring generated files labels Jul 30, 2026
minetwice and others added 2 commits July 30, 2026 22:50
…kin model

- Formatted textures.minecraft.net urls with HTTPS to prevent modern Minecraft clients from blocking skin requests.
- Parse skinModel ('slim' or 'classic') inside CraftynBackgroundLogin to automatically set arm thickness.
- Automatically synchronize and enable FEAR_Skin_Pack resource pack right before launch inside GameRunner.
- Added website tutorial for Mojang profile fallback and resigning in WEBSITE_SKIN_PROXY_CHANGES.txt.

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
@codeant-ai codeant-ai Bot added size:XXL This PR changes 1000+ lines, ignoring generated files and removed size:XXL This PR changes 1000+ lines, ignoring generated files labels Jul 30, 2026
…iplayer compatibility

This patch resolves the issue where imported skins are removed or fail to display when joining multiplayer Minecraft servers. It integrates an automated launch-time skin-sync routine in GameRunner that injects the active skin as a local resourcepack, and implements an authenticated local Yggdrasil-compliant HTTP Server (LocalSkinServer) with secure HTTPS texture URLs and Mojang profile resign-proxying.

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
@codeant-ai codeant-ai Bot added size:XXL This PR changes 1000+ lines, ignoring generated files and removed size:XXL This PR changes 1000+ lines, ignoring generated files labels Jul 30, 2026
… verification and online backend integration

This patch resolves the issue where custom skins are not shown on multiplayer servers by updating the launcher's AuthType to set the real Yggdrasil injectorUrl for CRAFTYN_MC accounts to 'https://farmer-my1t.onrender.com'. It updates LocalSkinServer.java with robust join and hasJoined session handshakes using signed profile responses. Furthermore, it details how the Node.js/Express backend (yggdrasil.js) must temporarily store join sessions and proxy unmatched queries with signature resigning using its own RSA keys to ensure standard multiplayer skin display for all players.

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
@codeant-ai codeant-ai Bot added size:XXL This PR changes 1000+ lines, ignoring generated files and removed size:XXL This PR changes 1000+ lines, ignoring generated files labels Jul 31, 2026
@codeant-ai codeant-ai Bot added size:XXL This PR changes 1000+ lines, ignoring generated files and removed size:XXL This PR changes 1000+ lines, ignoring generated files labels Jul 31, 2026
google-labs-jules Bot and others added 2 commits July 31, 2026 08:39
- Configure FEAR Network (CraftynMC) authlib-injector URL to point to the production custom skin and account server.
- Automatically extract authlib-injector.jar prior to launch and supply it dynamically in the launch JVM arguments.
- Build and implement an offline local Yggdrasil session handler (LocalSkinServer.java) on port 25599 for Local/Offline profiles to avoid skin loading crashes.
- Prevent crashes by restricting LocalSkinServer lifecycle to Local/Offline profiles only.
- Map SHA-256 texture digests and resolve fallback skin requests to official Mojang servers dynamically for robust skin handshakes.
- Include architectural documentation outlining necessary server-side Yggdrasil API handshakes for multiplayer skin support.

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
… offline-profile launch crashes

Co-authored-by: minetwice <207352315+minetwice@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant