Improve payload read diagnostics#19
Open
ericlewis wants to merge 3 commits into
Open
Conversation
When the loader cannot read /payload.bin, it now says which part failed and how many bytes it got. That makes the error easier to understand, like knowing which page of a book is missing instead of only knowing the book failed. Short reads are retried until the full header or body is read. The header is decoded as little-endian on purpose, and bad entry offsets now explain the exact problem before the loader stops.
This adds a small way to build a real payload.bin instead of guessing the file by hand. The helper puts the right 8-byte header in front of the raw payload, like putting a label on a package so the loader knows how big it is and where to start. CMake now builds hello-payload.bin as an example payload, CI runs the Python tests, releases include the example payload, and the README explains how to build and package custom payloads.
Add payload build system from merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
If /payload.bin fails to load, the old message only said the payload could not be read. This makes the loader say what went wrong in plain terms, so debugging is closer to seeing which page is missing instead of only knowing the whole book failed.
Verification