Generate loader startup include during build#10
Open
ericlewis wants to merge 3 commits into
Open
Conversation
Why: A new checkout did not have src/loader/start.inc because that file is generated and ignored by git. The loader still needs that file to compile, so the build failed unless someone knew to run a Python script first. This makes CMake run the generator and use the generated file from the build folder.
Why: The loader runs in the middle of Playdate firmware code. The firmware still needs its saved CPU values after the loader runs. Before this change, the loader call could change those values and make the firmware jump back to the wrong place or use the wrong inputs. This saves the important values, runs the loader, restores them, and then goes back to firmware.
ericlewis
added
build
Preserve firmware state in startup trampoline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
A new checkout does not have src/loader/start.inc because that file is generated and ignored by git. The loader still needs it to compile. This makes CMake run the generator so people do not need to know a hidden manual step.
Verification