test: strengthen panic assertions and add concurrent-panic coverage#14
Merged
Conversation
Replace silent `if p != nil` guards with `require.NotNil` so tests fail loudly when no panic is re-raised. Add Test_Group_MultiplePanics (both packages) to exercise the drop path when goroutines panic concurrently, Test_New_NilContext to cover the nil-context fallback in x/errgroup, and Test_exception_Nil as a white-box check of the nil branch in exception(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if p := recover(); p != nilguards withrequire.NotNilso panic tests fail loudly when no panic is re-raised (previously a missing panic silently passed)Test_Group_MultiplePanicsin both packages to exercise the drop path when N goroutines panic concurrently — verifies no deadlock or race under-raceTest_New_NilContextinx/errgroupto cover the nil-context fallback inNew(nil)Test_exception_Nilas a white-box test (internal package) for the nil branch ofexception()Test plan
make checkpasses (tidy, lint,go test -race ./...)🤖 Generated with Claude Code