chore: update PR checks and dev tooling#10
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Maintenance updates to dev tooling and CI so local setup and PR checks are more consistent and PR-focused.
Changes:
- Update Makefile targets to add
check-tidyand scope golangci-lint to changes via--new-from-rev. - Adjust PR workflow to run
make checkagainst the PR base branch and rename the job/step labels. - Minor tooling/docs updates: simplify
.golangci.yaml, update devcontainer post-create steps, and refineAGENTS.md.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Adds check-tidy, changes lint/fix to use --new-from-rev, and wires tidy into check. |
| AGENTS.md | Removes make fmt guidance; (needs updates to reflect new Makefile behavior). |
| .golangci.yaml | Removes “new issues only” settings now handled via CLI flags. |
| .github/workflows/pr-check.yml | Runs make check with NEW_FROM_REV=origin/${{ github.base_ref }} and renames the job. |
| .devcontainer/post_create.sh | Downloads Go modules during container setup. |
Comments suppressed due to low confidence (1)
AGENTS.md:56
- The command descriptions are now out of sync with the Makefile:
make fixalso runsgo mod tidyand uses--new-from-rev, andmake checknow includescheck-tidybefore lint/test. Please update this table/description to reflect the current behavior (and, ifNEW_FROM_REVis intended to be set in CI/local runs, document how to use it).
| `make lint` | Run linter (`golangci-lint run`) |
| `make fix` | Run linter with auto-fix (`golangci-lint run --fix`) |
| `make test` | Run all tests with race detector (`go test -v -race -failfast ./...`) |
| `make check` | Run `lint` then `test` (full CI gate) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update repository tooling and CI-related settings for smoother local setup and pull request checks.
Changes
.devcontainer/post_create.sh.github/workflows/pr-check.yml.golangci.yamlAGENTS.mdMakefileNotes