Skip to content

Allow a custom agent to be passed in#99

Open
CliffS wants to merge 8 commits into
mikeal:masterfrom
CliffS:master
Open

Allow a custom agent to be passed in#99
CliffS wants to merge 8 commits into
mikeal:masterfrom
CliffS:master

Conversation

@CliffS

@CliffS CliffS commented Apr 19, 2020

Copy link
Copy Markdown

This change allows a custom agent to be passed into the call to bent(). It will permit proxying both by use of a local proxy or a remote proxy. There may be other uses that can make use of a custom agent.

I have added one test via a squid server set up only to work against the usual test server.

@CliffS

CliffS commented May 18, 2020

Copy link
Copy Markdown
Author

@mikeal Do you dislike the principle behind this PR? If so I'll delete it.

@CliffS

CliffS commented Aug 11, 2020

Copy link
Copy Markdown
Author

@mikeal Please advise whether you want this PR, in which case I'll update it, or if you don't, in which case I'll simply close it.

Thanks.

Bring my version up to date with master.
@CliffS

CliffS commented May 19, 2021

Copy link
Copy Markdown
Author

Closing this PR owing to a lack of interest.

@Niklas-Dahlquist

Copy link
Copy Markdown

Can this topic be reopened? Would appreciate if proxies could be respected with bent

@CliffS

CliffS commented Oct 15, 2021

Copy link
Copy Markdown
Author

Can this topic be reopened? Would appreciate if proxies could be respected with bent

I'm happy to bring this up to date. But only if @mikeal wants it.

@Niklas-Dahlquist

Copy link
Copy Markdown

Can this topic be reopened? Would appreciate if proxies could be respected with bent

I'm happy to bring this up to date. But only if @mikeal wants it.

@mikeal Do you agree to this topic?

@SalAlba

SalAlba commented Oct 27, 2023

Copy link
Copy Markdown

................................................................................................
TypeError: Cannot convert object to primitive value
at RegExp.exec ()
at checkInvalidHeaderChar (node:_http_common:224:10)
at _node_internal (node:_http_outgoing:626:7)
at ClientRequest.setHeader (node:_http_outgoing:651:3)
at new ClientRequest (node:_http_client:291:14)
at Object.request (node:https:358:10)
at C:\node-sandbox\4-pro\node_modules\bent\src\nodejs.js:127:19
at new Promise ()
at C:\node-sandbox\4-pro\node_modules\bent\src\nodejs.js:126:10
at testMicrosoftTts (C:\node-sandbox\4-pro\testMicrosoftTts.js:46:32)
Cannot convert object to primitive value
................................................................................................

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants