Fix multipart/form-data being handled as json#135
Open
einkoro wants to merge 1 commit into
Open
Conversation
Do not add application/json content-type header or stringify the body when the body is an instanceof FormData.
|
I've tested this fix locally and it works great. It allows you to send form data using native For example: Since the content-type doesn't get set the browser is correctly able to use the |
|
For anyone who can't wait this PR to be merged, can use npm i mikeal/bent#pull/135/head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with web workers in the browser (or CloudFlare Workers) we do not have access to
FormData.getHeaders()to construct requests (example in #121 (comment)) and bent will default to application/json whereas fetch should handle the content type and boundary headers when passing an instance of FormData to it.This pull request changes bent to skip adding the application/json content-type header and stringifying the body when the body is an instanceof FormData.