fixes for /32 and /128 in ipset_sync as well as a change to the testing for existing ipsets - #4
Open
rfdrake wants to merge 3 commits into
Open
fixes for /32 and /128 in ipset_sync as well as a change to the testing for existing ipsets#4rfdrake wants to merge 3 commits into
rfdrake wants to merge 3 commits into
Conversation
For large lists this would be better because it doesn't have to load and then dump the list. Another alternative would be to run "ipset list -name | grep <listname>"
ipv4 /32 and ipv6 /128 shows up in the .set files with the CIDR, but when dumping the stored ipset it strips the CIDR for them. This just uses sed to take them out when doing the comparison.
mighq
pushed a commit
that referenced
this pull request
Feb 26, 2016
* they are show without CIDR in "ipset save" * but complete in config files * proposal from pull request #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also includes a commit with debian support, but I'm betting the ubuntu one currently in the PR may be better.