Skip to content

Fix issues with defaults options and some types - #18

Open
edausq wants to merge 1 commit into
mighq:masterfrom
edausq:fix/default-options
Open

Fix issues with defaults options and some types#18
edausq wants to merge 1 commit into
mighq:masterfrom
edausq:fix/default-options

Conversation

@edausq

@edausq edausq commented Feb 10, 2017

Copy link
Copy Markdown
Contributor

Default option 'family' is supported only by hash sets except for
hash:mac and default options 'hashsize' and 'maxelem' are supported only
by hash sets. This patch deletes from default_options theses options,
depending to the type name.

This fixes issues when working with some types

# ipset create foo bitmap:port family inet hashsize 1024 maxelem 6553
ipset v6.12.1: Unknown argument: `family'
Try `ipset help' for more information.

According to the man page

family { inet | inet6 }

This parameter is valid for the create command of all hash type sets except for hash:mac.

hashsize

This parameter is valid for the create command of all hash type sets.

maxelem

This parameter is valid for the create command of all hash type sets.

Default option 'family' is supported only by hash sets except for
hash:mac and default options 'hashsize' and 'maxelem' are supported only
by hash sets. This patch deletes from default_options theses options,
depending to the type name.
@edausq

edausq commented May 15, 2017

Copy link
Copy Markdown
Contributor Author

For information, this patch is in production for several months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant