fix(release): add eSheet submodule build step#236
Merged
Conversation
The release workflow was missing the 'Build eSheet submodule' step that CI already has. Without it, tsup fails to resolve @esheet/core, @esheet/builder, and @esheet/renderer imports during the build, blocking all npm publishes since the eSheet submodule was added in PR #227 (May 11).
Deploying ui with
|
| Latest commit: |
c14d4cb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8ff1dc40.ui-6d0.pages.dev |
| Branch Preview URL: | https://fix-release-esheet-submodule.ui-6d0.pages.dev |
There was a problem hiding this comment.
Pull request overview
Adds the missing "Build eSheet submodule" step to the release workflow so that tsup can resolve @esheet/* imports during the publish build, fixing publishes that broke after the eSheet submodule was introduced in #227.
Changes:
- Insert eSheet submodule build step in
.github/workflows/release.ymlbetween dependency install and lint, mirroring the same command used in all fourci.ymljobs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow was missing the 'Build eSheet submodule' step that CI already has. Without it, tsup fails to resolve @esheet/core, @esheet/builder, and @esheet/renderer imports during the build, blocking all npm publishes since the eSheet submodule was added in PR #227 (May 11).