fix(ci): resolve lint and format failures blocking release#235
Merged
Conversation
queueMicrotask is a standard Web/Node API (available since Node 11 and all modern browsers) but was missing from the ESLint globals config, causing a no-undef error in CommandPalette.test.tsx. This was blocking CI lint and preventing the Release workflow from publishing new npm versions since the CommandPalette PR was merged.
There was a problem hiding this comment.
Pull request overview
Adds queueMicrotask to the ESLint globals configuration to resolve a no-undef error in CommandPalette.test.tsx that was blocking CI lint and the Release workflow.
Changes:
- Add
queueMicrotask: 'readonly'to the globals list ineslint.config.js.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying ui with
|
| Latest commit: |
a33764a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d9c9153f.ui-6d0.pages.dev |
| Branch Preview URL: | https://fix-eslint-queuemicrotask-gl.ui-6d0.pages.dev |
Pre-existing Prettier violations that were blocking CI format check.
garrity-miepub
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queueMicrotask is a standard Web/Node API (available since Node 11 and all modern browsers) but was missing from the ESLint globals config, causing a no-undef error in CommandPalette.test.tsx.
This was blocking CI lint and preventing the Release workflow from publishing new npm versions since the CommandPalette PR was merged.